[cherry-pick] promote exception to property, add test (#3471) - #3486
Merged
Westin Musser (westin-m) merged 7 commits intoJul 22, 2026
Conversation
Westin Musser (westin-m)
marked this pull request as ready for review
May 13, 2026 17:44
Kelly🌠 (kllysng)
approved these changes
May 13, 2026
Westin Musser (westin-m)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Cherry-picks the fix from #3471 to address a blocking-path bug in ConfigurationManager<T> where metadata fetch failures could lose the original exception during the backoff window, preventing callers from classifying client (4xx) vs server (5xx) errors.
Changes:
- Promote the blocking-path fetch failure exception from a local variable to an instance field so it persists across calls within
_syncAfterbackoff. - Clear the persisted failure on successful retrieval/update to avoid stale errors.
- Add a regression test ensuring the inner exception (and
HttpDocumentRetriever.StatusCodeinException.Data) is preserved during the backoff window.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/ConfigurationManagerTests.cs | Adds a regression test verifying the blocking backoff path preserves the original inner exception/status code. |
| src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs | Introduces an instance field to persist the most recent blocking-path fetch failure across calls. |
| src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager_Blocking.cs | Uses the persisted failure field (set on failure, cleared on success) when throwing during the backoff window. |
Mallika Chennupaty (mdchennu)
approved these changes
Jul 21, 2026
Mallika Chennupaty (mdchennu)
left a comment
Mallika Chennupaty (mdchennu)
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, the comments added in the test were really helpful.
saurabhsathe-ms
approved these changes
Jul 22, 2026
debchoudhury-id4s
approved these changes
Jul 22, 2026
debchoudhury-id4s
left a comment
debchoudhury-id4s
left a comment
Contributor
There was a problem hiding this comment.
was there a blocker preventing backporting #3471 earlier? Or was this timing intentional? Asking to learn about any possible release improvement.
Contributor
Author
The only blocker was lack of reviews |
This was referenced Jul 29, 2026
Merged
This was referenced Aug 6, 2026
Closed
Open
nuget: Bump Microsoft.IdentityModel.JsonWebTokens from 8.0.1 to 8.22.0
VertexSelection/MeloVertex#49
Open
Sondre Sjølyst (sondresjolyst)
pushed a commit
to sondresjolyst/nstuning-api
that referenced
this pull request
Aug 9, 2026
…22.0 (#104) Updated [System.IdentityModel.Tokens.Jwt](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) from 8.21.0 to 8.22.0. <details> <summary>Release notes</summary> _Sourced from [System.IdentityModel.Tokens.Jwt's releases](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases)._ ## 8.22.0 ## What's Changed * Promote exception to property, add test by @westin-m in AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#3486 * Add IgnoreCaseWhenValidatingAudience flag to audience validation by @cpp11nullptr in AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#3563 **Full Changelog**: AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet@8.21.0...8.22.0 Commits viewable in [compare view](AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet@8.21.0...8.22.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick #3471 into dev/8x